Generator::getTitle(): improve libxml cross-version compatibility - #1485
Merged
jrfnl merged 1 commit intoAug 17, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The format of the `DOMDocument::$documentURI` value on PHP 8.6 on Windows has changed due to changes in `libxml` `21500`. This commit updates the code in the `Generator::getTitle()` method to handle the filename format in a manner which is cross-version compatible with both `libxml` < 21500 and well as >= 21500 and should work on both *nix as well as Windows. This change should fix the test failure for PHP 8.6 on Windows. Refs: * php/php-src#23326 * php/php-src@bc7537d
jrfnl
deleted the
php-8.6/generator-gettitle-make-libxml-cross-version-compatible
branch
August 17, 2026 00:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The format of the DOMDocument::$documentURI value on PHP 8.6 on Windows has changed due to changes in libxml 21500.
This commit updates the code in the Generator::getTitle() method to handle the filename format in a manner which is cross-version compatible with both libxml < 21500 and well as >= 21500 and should work on both *nix as well as Windows.
This change should fix the test failure for PHP 8.6 on Windows.
Refs:
Suggested changelog entry