Do not add layer2 interfaces to a virtual router - #461
Open
m4rcu5 wants to merge 1 commit into
Open
m4rcu5 wants to merge 1 commit into
m4rcu5 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent layer2 interfaces being added to virtual routers
Motivation and Context
The origin of this PR stems downstream from pan-os-ansible, where adding a aggregate interface with mode set to layer2 results in an error. This error seems to be due to the network module trying to add the layer2 interface to a virtual-router.
code example
As layer2 interfaces do not have any routable properties, and cannot be added to a virtual-router in the PAN-OS interface, they should be excluded.
downstream error message
The full traceback is: File "/tmp/ansible_panos_aggregate_interface_payload_8n5bzkkx/ansible_panos_aggregate_interface_payload.zip/ansible_collections/paloaltonetworks/panos/plugins/modules/panos_aggregate_interface.py", line 297, in main File "/home/mvandam/.local/lib/python3.10/site-packages/panos/network.py", line 433, in set_virtual_router return self._set_reference( File "/home/mvandam/.local/lib/python3.10/site-packages/panos/base.py", line 1664, in _set_reference obj.update(reference_var) File "/home/mvandam/.local/lib/python3.10/site-packages/panos/base.py", line 712, in update device.xapi.edit( File "/home/mvandam/.local/lib/python3.10/site-packages/panos/base.py", line 3899, in method raise the_exception fatal: [fra01.lsvpn-hub.leaseweb.org]: FAILED! => { "changed": false, "invocation": { "module_args": { "adjust_tcp_mss": null, "api_key": null, "comment": null, "commit": false, "create_dhcp_default_route": null, "dhcp_default_route_metric": null, "enable_dhcp": null, "if_name": "ae2", "ip": null, "ip_address": null, "ipv4_mss_adjust": null, "ipv6_enabled": null, "ipv6_mss_adjust": null, "lacp_enable": true, "lacp_mode": null, "lacp_passive_pre_negotiation": null, "lacp_rate": null, "lldp_enabled": true, "lldp_profile": "default", "management_profile": null, "mode": "layer2", "mtu": null, "netflow_profile": null, "password": null, "port": 443, "provider": {}, "state": "present", "template": null, "username": "admin", "vr_name": "default", "vsys": null, "zone_name": null } }, "msg": "Failed setref: interface 'ae2' is not a valid reference" }How Has This Been Tested?
I have tested and can confirm that layer2 and layer3 aggregate interfaces are now correctly deployed. This has been tested against PAN-OS 10.1.6
Types of changes
Checklist