FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ha): clear stale ha_failed when refreshing HA active state by krystian-elisity · Pull Request #622 · PaloAltoNetworks/pan-os-python · GitHub

/ pan-os-python Public

fix(ha): clear stale ha_failed when refreshing HA active state #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krystian-elisity wants to merge 1 commit into
base: develop
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 0 Commits 1 Checks 0 Files changed
Open

fix(ha): clear stale ha_failed when refreshing HA active state #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 2 additions & 0 deletions panos/base.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -4765,6 +4765,8 @@ def refresh_ha_active(self):
else:
for fw, state in ((self, self_state), (self.ha_peer, peer_state)):
fw._ha_active = state == "active"
# Reached this device for its state, so it is no longer failed.
fw.ha_failed = False
return self_state

def synchronize_config(self):
Expand Down
42 changes: 42 additions & 0 deletions tests/test_firewall.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@

import unittest

# Python 2 has no unittest.mock; fall back to the standalone mock package.
try:
from unittest import mock
except ImportError:
import mock

import panos
import panos.firewall

Expand Down Expand Up @@ -51,5 +57,41 @@ def test_id_returns_no_id(self):
self.assertEqual(expected, ret_val)


class TestFirewallHa(unittest.TestCase):
def _ha_pair(self):
fw = panos.firewall.Firewall("10.0.0.1", "user", "pass")
peer = panos.firewall.Firewall("10.0.0.2", "user", "pass")
fw.set_ha_peers(peer)
return fw, peer

def test_refresh_ha_active_clears_stale_ha_failed(self):
"""A live state refresh clears ha_failed on the reachable device."""
fw, peer = self._ha_pair()
# A transient error failed this device and promoted the peer to active.
fw.set_failed()
self.assertTrue(fw.ha_failed)
# Live HA now reports this device is active again.
fw.show_highavailability_state = mock.Mock(return_value=("active", None))
peer.show_highavailability_state = mock.Mock(return_value=("passive", None))

fw.refresh_ha_active()

self.assertFalse(fw.ha_failed)

def test_refresh_ha_active_keeps_ha_failed_when_state_not_authoritative(self):
"""A non-authoritative state (initial/disabled) leaves ha_failed untouched."""
fw, peer = self._ha_pair()
# A transient error failed this device.
fw.set_failed()
self.assertTrue(fw.ha_failed)
# HA is still initializing, so the reported state is not authoritative.
fw.show_highavailability_state = mock.Mock(return_value=("initial", None))
peer.show_highavailability_state = mock.Mock(return_value=("active", None))

fw.refresh_ha_active()

self.assertTrue(fw.ha_failed)


if __name__ == "__main__":
unittest.main()
Back | FazBrowse Home | New Git URL