Fix ICMP type and code types in application object - #627
Open
ben-astsec wants to merge 1 commit into
Open
ben-astsec wants to merge 1 commit into
ben-astsec wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it so ICMP type/code inside of an application object supports ranges.
Motivation and Context
I was trying to parse a certain configuration and failed because the ICMP type value was a range in there, and I got an error:
This was caused because ApplicationObject.default_icmp_type and ApplicationObject.default_icmp_code had a varty pe="int", even though the configuration can contain ranges.
How Has This Been Tested?
Added a test that makes sure that application objects accept icmp codes/types that are ranges.
Types of changes
Checklist