Hello,

Thanks for the interest.

What is this PR for? SFTPHandle.closed is already a public attribute.

What is this PR for? SFTPHandle.closed is already a public attribute.

The cdef bint closed attribute does not seem to be visible on the Python side, preventing certain usages of an SFTPHandle as file. Also apparently cpdef does not support bint attribute.

import ssh2.sftp_handle
ssh2.sftp_handle.SFTPHandle(None).closed

What is this PR for? SFTPHandle.closed is already a public attribute.

The cdef bint closed attribute does not seem to be visible on the Python side, preventing certain usages of an SFTPHandle as file. Also apparently cpdef does not support bint attribute, hence the need for property wrappers. Am I overlooking something?

import ssh2.sftp_handle
ssh2.sftp_handle.SFTPHandle(None).closed

@pkittenis

The cdef bint closed attribute does not seem to be visible on the Python side, preventing certain usages of an SFTPHandle as file.

Is there some example code that is not working or causing errors I can look at?

Edit - here:

from ssh2.sftp_handle import SFTPHandle
hh = SFTPHandle(None)
hh.closed

Traceback (most recent call last):
  File "<python-input-6>", line 1, in <module>
    hh.closed
AttributeError: 'ssh2.sftp_handle.SFTPHandle' object has no attribute 'closed'. Did you mean: 'close'?

This needs added as a test to check the changes work. Changes look good otherwise.

Done in #226 .

Can see why tests are needed in that PR. Just changing the internal property to public is not enough.