Chainable base controller support - #48
Draft
henningkayser wants to merge 5 commits into
Draft
henningkayser wants to merge 5 commits into
henningkayser wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
henningkayser
force-pushed
the
base_controller_support
branch
from
2f01c74 to
cfc3e56
Compare
March 18, 2024 13:12
pac48
reviewed
Jun 4, 2025
pac48
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
@EzraBrooks Can we close this?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a controller chain including a JTC and a DiffDriveController for the base.
I would recommend merging this only after the upstream dependencies have been merged.
Depends on: