Type Handlers - #1237
Open
PiggyPiglet wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Why the rush? Just wait with making this in all honesty. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Not really any rush, doubt this will be ready for next release |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Type
Description
Closes #1208
This is an idea from PAPI3, however the implementation in this version doesn't exactly match what it would've in papi 3.
A developer could for example have something like
and should a type handler for Location be registered, that type handler could then provide placeholders like _x, _y, etc, allowing for a standarised format and predictable results across all expansions returning a specific type versus independent implementations that may differ.
I'm not happy with the implementation or api design here... at all, but I only had 2 hours to work on this so that's where we're at. In a perfect world a type handler would attach directly to an expansion and for example %player_x% would work, wouldn't need %player_loc_x%, however that's out of scope for tonight.