Hello @lemmatum! Thanks for updating your pull request.

• In the file SpectroscoPyx/diagnostics/filters/filtersHenke.py, following are the PEP8 issues :

Line 21:1: E265 block comment should start with '# '
Line 21:1: E303 too many blank lines (3)
Line 29:1: E265 block comment should start with '# '
Line 30:1: E265 block comment should start with '# '
Line 31:1: E265 block comment should start with '# '
Line 32:1: E265 block comment should start with '# '
Line 34:1: E265 block comment should start with '# '
Line 36:1: E265 block comment should start with '# '
Line 37:1: W293 blank line contains whitespace
Line 39:1: E265 block comment should start with '# '
Line 40:1: E265 block comment should start with '# '
Line 41:1: E265 block comment should start with '# '
Line 42:1: E265 block comment should start with '# '
Line 43:1: E265 block comment should start with '# '
Line 44:1: E265 block comment should start with '# '
Line 47:1: E265 block comment should start with '# '
Line 50:32: E203 whitespace before ':'
Line 51:36: E203 whitespace before ':'
Line 52:38: E203 whitespace before ':'
Line 53:36: E203 whitespace before ':'
Line 54:27: E203 whitespace before ':'
Line 55:36: E203 whitespace before ':'
Line 56:28: E203 whitespace before ':'
Line 57:29: E203 whitespace before ':'
Line 58:33: E203 whitespace before ':'
Line 59:33: E203 whitespace before ':'
Line 63:1: E303 too many blank lines (3)
Line 82:1: W293 blank line contains whitespace
Line 89:1: W293 blank line contains whitespace
Line 90:1: W293 blank line contains whitespace
Line 91:5: E303 too many blank lines (2)
Line 95:1: W293 blank line contains whitespace
Line 96:1: W293 blank line contains whitespace
Line 97:5: E303 too many blank lines (2)
Line 106:36: E231 missing whitespace after ','
Line 107:41: E231 missing whitespace after ','
Line 120:1: W293 blank line contains whitespace
Line 143:1: W293 blank line contains whitespace
Line 149:8: E713 test for membership should be 'not in'
Line 163:1: W293 blank line contains whitespace
Line 164:1: W293 blank line contains whitespace
Line 165:5: E303 too many blank lines (2)
Line 168:48: E261 at least two spaces before inline comment
Line 170:29: E203 whitespace before ':'
Line 171:31: E203 whitespace before ':'
Line 172:26: E203 whitespace before ':'
Line 173:25: E203 whitespace before ':'
Line 174:25: E203 whitespace before ':'
Line 175:26: E203 whitespace before ':'
Line 176:26: E203 whitespace before ':'
Line 177:28: E203 whitespace before ':'
Line 180:52: W291 trailing whitespace
Line 181:62: W291 trailing whitespace
Line 201:1: E265 block comment should start with '# '
Line 202:1: E265 block comment should start with '# '
Line 208:1: E305 expected 2 blank lines after class or function definition, found 1
Line 216:1: W391 blank line at end of file

Comment last updated on July 04, 2018 at 05:25 Hours UTC

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   64.86%   64.86%           
=======================================
  Files           9        9           
  Lines         111      111           
=======================================
  Hits           72       72           
  Misses         39       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eecde8c...272fc61. Read the comment docs.