FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix dividend bugs by adamdossa · Pull Request #606 · PolymathNetwork/polymath-core · GitHub

/ polymath-core Public

Fix dividend bugs - #606

Merged
satyamakgec merged 6 commits into
dev-2.1.0from
fix_dividend_bugs
Mar 19, 2019
ConversationCommits (6)ChecksFiles changed
Merged

Fix dividend bugs#606
satyamakgec merged 6 commits into
dev-2.1.0from
fix_dividend_bugs

Conversation

adamdossa commented Mar 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • move DummySTO (and associated factory) to the mocks folder and add a payable fallback function to test reclaiming ETH & ERC20.
  • add a reclaimETH function to STO.sol to allow any ETH that may become locked in an STO contract to be reclaimed by the issuer.
  • make Dividend contracts (ERC20 & Ether) pausable, with pulling dividends only possible when the contract is not paused. All other functions do not depend on being paused, but are open only to authorised addresses.
  • allow the issuer to update maturity & expiry dates on existing dividends. This can be used to postpone a dividend (pushing back the maturity) or make a dividend reclaimable (making expiry earlier than now) or to correct mistakes when originally creating the dividend. NB - changing these dates may cause a dividend to no longer be valid for payments (e.g. setting it's expiry to be in the past, or it's maturity to be in the future).
  • small refactor to validDividendIndex to reduce contract size
  • add reclaimETH and reclaimERC20 to Dividend contracts (ERC20 & Ether). This allows (in an emergency) any funds to be pulled out of a dividend contract by the issuer.
  • fix bug in _payDividend Dividend function (ERC20 & Ether) when withholding tax is 100%
  • improve test cases (add a test for reclaiming ETH & ERC20 tokens from STO and 100% withholding tax in Dividends, and for pausing / updating dates / reclaiming ETH / ERC20 from Dividend contracts)

adamdossa changed the title Fix dividend bugs WIP: Fix dividend bugs Mar 18, 2019
adamdossa changed the title WIP: Fix dividend bugs Fix dividend bugs Mar 18, 2019
adamdossa requested review from maxsam4 and satyamakgec and removed request for maxsam4 March 18, 2019 21:26

coveralls commented Mar 18, 2019

Copy link
Copy Markdown

Coverage decreased (-0.04%) to 96.606% when pulling 219f24e on fix_dividend_bugs into 0008f28 on dev-2.1.0.

satyamakgec merged commit a90d729 into dev-2.1.0 Mar 19, 2019
satyamakgec mentioned this pull request Mar 19, 2019
Merged
satyamakgec deleted the fix_dividend_bugs branch October 30, 2019 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
maxsam4 maxsam4 approved these changes
satyamakgec satyamakgec approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL