Fixes incorrect directory metadata - #7
Merged
Potherca merged 23 commits intoApr 19, 2016
Merged
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
Potherca
force-pushed
the
issues/6/incorrect-directory-metadata
branch
from
e4205f8 to
53e6dc1
Compare
April 3, 2016 19:45
Copy link
Copy Markdown
Owner
Author
|
Functionality should work as-is. The unit-tests need to be amended and then this can be merged. |
Sorry, something went wrong.
- Only directories should return content, for a file an empty array should be returned.
- Adds specific check for directories - Removes guessing by extension as this gives a different result from regular filesystem behaviour
- The original logic did not properly display all directory content for non-recursive cases when a path was provided.
- Visibility is now assumed to be visible by default - Bug in permission comparison is fixed
- Timestamps for files are retrieved from the github api - Timestamps for directories are calculated from retrieved files
- Uses shorter alias for MockObject instead of FQN - Adds trailing comma to entries in data provider - Removes test that is no longer relevant
…I class - Data for metadata is always retrieved recursively. - Marks Api::getCreatedTimestamp() as being used by Api::getRecursiveMetadata()
- Changed mock data to match changed normalisation format from Api class - Changed mock data to match the fact that metadata is always retrieved recursively - Adds Api::getCreatedTimestamp() as being used by Api::getRecursiveMetadata() - Adds mock for Commits Repository
…erface::getTreeMetadata().
Copy link
Copy Markdown
Owner
Author
|
Existing unit-tests have been fixed. Code-coverage for newly added functionality needs to be added. |
Sorry, something went wrong.
Potherca
force-pushed
the
issues/6/incorrect-directory-metadata
branch
from
d993333 to
2637017
Compare
April 16, 2016 18:46
…ntents() - Adds keys to provided data for easy idintifiaction in case of failure - Adds JSON file as fixture
Copy link
Copy Markdown
Owner
Author
|
Tests covering directory functionality have been added. Ready to merge. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return values of metadata for directories is incorrect as mentioned in issue #6.
This pull request resolves that issue.