Fix IsMutexPresent() to avoid incorrect use of GetLastWin32Error() - #4910
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoAug 28, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Andy Jordan (andyleejordan)
requested review from
Patrick Meinecke (SeeminglyScience) and
Dongbo Wang (daxian-dbw)
August 28, 2025 00:28
Comment thread
PSReadLine/PlatformWindows.cs
Outdated
| try | ||
| { | ||
| using var mutex = new System.Threading.Mutex(false, name); | ||
| return Marshal.GetLastWin32Error() == ERROR_ALREADY_EXISTS; |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Patrick Meinecke (@SeeminglyScience) astutely pointed out this is bad, as we're not exactly making a system call when gettingn the mutex. It should be TryOpenExisting.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
And fixed. Thanks!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Sorry, I just saw this after merging #4854. Please submit a new PR for the fix.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I already updated this one 😄
Sorry, something went wrong.
Andy Jordan (andyleejordan)
force-pushed
the
accessibility
branch
2 times, most recently
from
df27716 to
df72935
Compare
August 28, 2025 18:39
Since we're not actually making a system call.
Andy Jordan (andyleejordan)
force-pushed
the
accessibility
branch
from
df72935 to
db135b5
Compare
August 28, 2025 18:39
Dongbo Wang (daxian-dbw)
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're not actually making a system call.