Fix a null reference exception when showing parameter help - #4971
Merged
Dongbo Wang (daxian-dbw) merged 2 commits intoOct 16, 2025
Merged
Fix a null reference exception when showing parameter help#4971Dongbo Wang (daxian-dbw) merged 2 commits into
Dongbo Wang (daxian-dbw) merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
3 tasks
Dongbo Wang (daxian-dbw)
marked this pull request as ready for review
October 16, 2025 17:08
Patrick Meinecke (SeeminglyScience)
approved these changes
Oct 16, 2025
Patrick Meinecke (SeeminglyScience)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #4960
The null reference is caused by the expression helpContent.type.name in the code. helpContent is a dynamic object that's guaranteed to not be null, and in a rare case, helpContent.type is null, so null reference exception gets thrown.
It's fixed by using helpContent.type?.name. Kris Borowinski (@kborowinski) kindly validated and confirmed the fix (THANK YOU!).
Microsoft Reviewers: Open in CodeFlow