| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
…wershell dep resolution, add warning when filtering libs
…FM or RID is specified
|
Justin Chung (@jshigetomi) is this PR still needed? were you able to add tests? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Adds automatic RID (Runtime Identifier) and TFM (Target Framework Moniker) filtering during package extraction, plus two new parameters (-RuntimeIdentifier, -TargetFramework) for explicit cross-platform/cross-framework deployment.
Design Decisions for Review
1. Root-level RID folders, not NuGet runtimes/ convention
PowerShell modules use win-x64/, linux-x64/ at the package root for native assets, not the standard NuGet runtimes/{rid}/native/ layout. Filtering targets this PS-ecosystem convention.
2. Merge semantics on re-install with explicit overrides
This enables incremental multi-target builds:
3. Singular TFM selection — no fallback extraction
NuGet.Frameworks.FrameworkReducer picks the single best-match TFM from lib/. Only that TFM's assemblies are extracted — no fallback that extracts multiple TFMs. This prevents accidental cross-lineage mixing but means users must explicitly merge if they need both.
4. Cross-lineage warning
When the selected TFM is .NETCoreApp but the package also has net472 (or vice versa), a non-fatal warning tells the user how to add the other lineage:
PR Context
Platform aware installation was brought up in issue: MicrosoftDocs/PowerShell-Docs#794.
PR Checklist