Update AzF profile to be useful - #1341
Merged
Rob Holt (rjmholt) merged 3 commits intoSep 14, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Looks ok to me but it broke 1 CI test:
Context Targeting new-form Az profiles alongside older profiles
[-] Finds AzF problems with a script 7.37s
KeyNotFoundException: The given key 'InDisconnectedSession' was not present in the dictionary.
at <ScriptBlock>, C:\projects\psscriptanalyzer\Tests\Rules\UseCompatibleCommands.Tests.ps1: line 334
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Impressive that testing picked that up! I'll have to make some further edits |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Have to credit you entirely for that Christoph Bergmeister (@bergmeister) -- you asked for those tests. Looks like they're working now. Hopefully the Lazys don't hide other faults. I took out parameters and commands manually, and it looks like I took a parameter out without its alias there. |
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
approved these changes
Sep 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I've run the profile collector on the AzF profile (with some difficulty) and collected a new profile that captures the default Az installation.
I've also removed cmdlets that don't work in AzF despite being present, like Start-Job and Enter-PSSession.
I had to make some small changes to the profile collector to not crash (plus one where I realised that collecting a function if we're not able to load it is unhelpful).
PR Checklist