Harden handling when getting the installed dotnet cli version - #1367
Merged
Christoph Bergmeister (bergmeister) merged 1 commit intoNov 13, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
James Truher (JamesWTruher)
requested review from
Christoph Bergmeister (bergmeister) and
Rob Holt (rjmholt)
November 5, 2019 19:42
Christoph Bergmeister (bergmeister)
approved these changes
Nov 5, 2019
Closed
6 tasks
dotnet --version can now emit a list of installed sdks as output *and* an error if the global.json file points to a version of the sdk which is *not* installed. However, the format of the new list with --version has a couple of spaces at the beginning of the line, so we need to be resilient against that.
James Truher (JamesWTruher)
force-pushed
the
BuildScriptFix01
branch
from
41c8013 to
ffe499c
Compare
November 11, 2019 22:49
Rob Holt (rjmholt)
approved these changes
Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
dotnet --version can now emit a list of installed sdks as output and an error if the global.json
file points to a version of the sdk which is not installed. However, the format of the new list
with --version has a couple of spaces at the beginning of the line, so we need to be resilient
against that.
PR Checklist