Fix typo in example - #1379
Conversation
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
left a comment
There was a problem hiding this comment.
Thanks for making it consistent.
I am happy with the proposed change but I think we could improve it further by making 2 more changes:
- Use the full parameter name, which is -Settings in both examples
- Replace PSScriptAnalyzerSettings.psd1 in the 2 examples with $PSScriptAnalyzerSettingsPath. This is because using -Settings PSScriptAnalyzerSettings.psd1 is redundant due to the implicit settings feature.
Let me know what you think.
Sorry, something went wrong.
|
I agree with the use of -Settings. I wouldn't use the variable, it just adds confusion over the meaning of the variable. The current use of PSScriptAnalyzerSettings.psd1 as a filename shows the examples as they apply to both the implicit use and by user supplied path. |
Sorry, something went wrong.
|
Ok, happy with that as well, it is definitely an improvement. Thanks 😀 |
Sorry, something went wrong.
Correct the script name to match the name in the example.
Removed the when using. It belonged with the when using Invoke-ScriptAnalyzer used in the previous example and repeating that seems unnecessary.