Fix false positive of AvoidAlias rule for implicit aliasing of Get- commands for the CommandType ExternalScript - #1386
Merged
Christoph Bergmeister (bergmeister) merged 2 commits intoJan 28, 2020
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…ommands for the CommandType ExternalScript
Christoph Bergmeister (bergmeister)
requested review from
James Truher (JamesWTruher) and
Rob Holt (rjmholt)
January 2, 2020 22:02
James Truher (JamesWTruher)
approved these changes
Jan 28, 2020
James Truher (JamesWTruher)
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This looks great - do we need any additional validation, or is what we have sufficient?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
The manual end to end test (in vs code) is all I could as somehow this happens only when PSSA is hosted in the vs code extension where those command info cache entries got populated. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1369
Unfortunately this issue could only be reproduced when PSSA is hosted within PSES where the root of the workspace becomes the working directory of the runspace pool, which causes Get-Command ..\PathToScript.ps1 to return a command type of ExternalScript, which then makes it into the command cache and causes the false positve.
The fix is to search only for cmdlets/functions where the implicit Get- aliasing applies.
PR Checklist