FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove obsolete GetCommandInfoLegacy method and use GetCommandInfo instead by bergmeister · Pull Request #1387 · PowerShell/PSScriptAnalyzer · GitHub

Remove obsolete GetCommandInfoLegacy method and use GetCommandInfo instead - #1387

Merged
Christoph Bergmeister (bergmeister) merged 1 commit into
PowerShell:masterfrom
bergmeister:RemoveLegacyMethods
Jan 3, 2020
Merged

Remove obsolete GetCommandInfoLegacy method and use GetCommandInfo instead#1387
Christoph Bergmeister (bergmeister) merged 1 commit into
PowerShell:masterfrom
bergmeister:RemoveLegacyMethods

Conversation

Copy link
Copy Markdown
Collaborator

PR Summary

In the past we could not remove them because it broke tests but now it seems that tests are OK.
There is a risk for a regression that is not covered by tests but especially with the new way of PSSA being hosted, it feels more worth of a try now.

PR Checklist

Christoph Bergmeister (bergmeister) changed the title Remove legacy methods Remove obsolete GetCommandInfoLegacy method and use GetCommandInfo instead Jan 3, 2020
Christoph Bergmeister (bergmeister) merged commit 1c0cfef into PowerShell:master Jan 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL