Remove redundant whitespace between parameters with new option (disabled by default) in UseConsistentWhitespace - #1392
Merged
Christoph Bergmeister (bergmeister) merged 9 commits intoJan 7, 2020
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
requested review from
James Truher (JamesWTruher) and
Rob Holt (rjmholt)
January 6, 2020 17:58
Comment thread
Rules/UseConsistentWhitespace.cs
Outdated
Comment thread
Rules/UseConsistentWhitespace.cs
Outdated
Comment thread
Rules/UseConsistentWhitespace.cs
Outdated
Comment thread
Rules/UseConsistentWhitespace.cs
Outdated
Comment thread
Rules/UseConsistentWhitespace.cs
Outdated
Comment thread
Rules/UseConsistentWhitespace.cs
Comment thread
Rules/UseConsistentWhitespace.cs
Outdated
Comment thread
Rules/UseConsistentWhitespace.cs
Outdated
Comment thread
Rules/UseConsistentWhitespace.cs
Outdated
Comment thread
Tests/Rules/UseConsistentWhitespace.tests.ps1
Co-Authored-By: Robert Holt <rjmholt@gmail.com>
…ghtExtent variable, which broke build. Variable is used 2 times and makes code more readable, therefore keeping it
Copy link
Copy Markdown
Collaborator
Author
|
Rob Holt (@rjmholt) Thanks for the review, I addressed all recommendations |
Sorry, something went wrong.
Rob Holt (rjmholt)
approved these changes
Jan 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Disabled by default because it is new. The plan is to later add an option to the vs code extension and pending positive feedback we can then later enable it by default.
The only case that was excluded by design is when the user uses the -ParameterName:$ParameterValue syntax as some people might prefer 0 or 1 whitespace here, the rule leaves those cases completely untouched.
PR Checklist