Use AST to determine SupportsShouldProcess when an error is thrown - #1397
Merged
Christoph Bergmeister (bergmeister) merged 7 commits intoFeb 8, 2020
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
Rules/UseShouldProcessCorrectly.cs
Outdated
Copy link
Copy Markdown
Collaborator
|
Code change looks ok but the build says it has a problem when targeting psv3, looks like we need a pragma using the PSV3 variable UseShouldProcessCorrectly.cs(382,99): error CS1061: 'ExpressionAst' does not contain a definition for 'SafeGetValue' and no accessible extension method 'SafeGetValue' accepting a first argument of type 'ExpressionAst' could be found (are you missing a using directive or an assembly reference?) |
Sorry, something went wrong.
Co-Authored-By: Christoph Bergmeister [MVP] <c.bergmeister@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
Ok I've repurposed the SafeGetValue substitute method I wrote to handle that. It's now available as a Helper method. |
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
approved these changes
Feb 8, 2020
Christoph Bergmeister (bergmeister)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Looks good to me. I verified that the diff in Helper.cs/Settings.cs is mainly just the move to make the method publicly accessible.
Only an optional style suggestion.
Sorry, something went wrong.
Comment thread
Rules/UseShouldProcessCorrectly.cs
Outdated
Comment thread
Rules/UseShouldProcessCorrectly.cs
Outdated
Co-Authored-By: Christoph Bergmeister [MVP] <c.bergmeister@gmail.com>
Co-Authored-By: Christoph Bergmeister [MVP] <c.bergmeister@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1217.
When PowerShell throws an error due to not being able to resolve an attribute type, we sift through the AST to determine whether SupportsShouldProcess has been set on a function.
Also cleans up some of the logic so it's not all nested ass.
PR Checklist