Multi-stage pipelines (to split build->test) by bergmeister · Pull Request #1404 · PowerShell/PSScriptAnalyzer · GitHub

PR Summary

This also makes the test matrix much bigger because it's free due to parallelism.

Somehow this also exposed a small bug in a rule around newlines that I had to fix as part of it.

PR Checklist

PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

…are latest ubuntu image

…ebugging info

…t on Linux

…rsion

… into multi-stage-yaml # Conflicts: # .azure-pipelines-ci/ci.yaml # .azure-pipelines-ci/templates/unix.yaml

Christoph Bergmeister (bergmeister) and others added 16 commits February 2, 2020 16:19

try using multi-job yaml with different images

e7a7c54

fix indentation

2e4c403

add vm images to windows build and templatify unix build. Images now …

e669e48

…are latest ubuntu image

trigger

ca51510

fix yaml path

ac4894c

disable sporadic tests generally and add both Ubuntu images to the tests

d2188be

job name in quotes and disable redundant appveyor matrix entries

ba896ab

whitespace not allowed for job name

c50c02a

dots arent allowed either...

ec0fcb7

last fix

4afd0c6

Merge all entry path yaml files into one yaml.ci file

a503c15

fix windows powershell job

e31aead

tweak step name for ps5 to be consistent

06d6631

re-trigger

9c4445b

add badge

dfe241a

multi stage build-test

58df168

Christoph Bergmeister (bergmeister) added the Area - Build label Feb 3, 2020

Christoph Bergmeister added 8 commits February 3, 2020 07:30

bootstrap pester

b4ef261

Cleanup and avoid Pester bootstrap in build stage

2623e58

download pipeline artifact in test stage

c7bbb5f

try fix artifact download path

270bb78

try fix artifact path using '$(Build.SourcesDirectory)/out' and add d…

db7d529

…ebugging info

fix ps syntax

7a13f38

remove debugging step

ca2c14c

Fix suggestion text to have platform specific newlines and enable tes…

e4717dd

…t on Linux

Christoph Bergmeister (bergmeister) changed the title WIP: Multi stage yaml WIP: Multi-stage pipelines (to split build->test) Feb 3, 2020

Christoph Bergmeister added 4 commits February 3, 2020 13:01

add more windows images

4459f9e

try use strategy

c34fb1a

try

164bca3

fix job name

329f712

Christoph Bergmeister added 3 commits February 3, 2020 15:09

rename and try to not use a job name

f5edd4e

remove pwsh variable, which is now redundant as it is now in test.yaml

5c8bb36

remove old comment

06309b8

Christoph Bergmeister (bergmeister) changed the title WIP: Multi-stage pipelines (to split build->test) Multi-stage pipelines (to split build->test) Feb 3, 2020

Christoph Bergmeister (bergmeister) changed the title Multi-stage pipelines (to split build->test) WIP Multi-stage pipelines (to split build->test) Feb 3, 2020

Christoph Bergmeister added 3 commits February 3, 2020 17:05

try fix tests on wmf4

6ff0c07

try use -be instead of -match operator

bb95ab4

fix wmf4 test failure due to CRLF not being correctly used in this ve…

8eaf6fd

…rsion

Christoph Bergmeister (bergmeister) changed the title WIP Multi-stage pipelines (to split build->test) Multi-stage pipelines (to split build->test) Feb 3, 2020

Christoph Bergmeister (bergmeister) marked this pull request as ready for review February 3, 2020 23:16

Merge branch 'master' of https://github.com/powershell/psscriptanalyzer …

20e5b1b

… into multi-stage-yaml # Conflicts: # .azure-pipelines-ci/ci.yaml # .azure-pipelines-ci/templates/unix.yaml

Christoph Bergmeister (bergmeister) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) February 3, 2020 23:20

Rob Holt (rjmholt) approved these changes Feb 4, 2020

View reviewed changes

Comment thread .azure-pipelines-ci/ci.yaml Outdated

make pscompatiblitycollector build against all frameworks again

9f81fab

Christoph Bergmeister (bergmeister) merged commit 1305c88 into PowerShell:master Feb 4, 2020

Multi-stage pipelines (to split build->test) by bergmeister · Pull Request #1404 · PowerShell/PSScriptAnalyzer · GitHub

Uh oh!

Multi-stage pipelines (to split build->test) - #1404

Multi-stage pipelines (to split build->test)#1404
Christoph Bergmeister (bergmeister) merged 36 commits into
PowerShell:masterfrom
bergmeister:multi-stage-yaml

Christoph Bergmeister (bergmeister) commented Feb 3, 2020 •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Multi-stage pipelines (to split build->test) by bergmeister · Pull Request #1404 · PowerShell/PSScriptAnalyzer · GitHub

Uh oh!

Multi-stage pipelines (to split build->test) - #1404

Multi-stage pipelines (to split build->test)#1404Christoph Bergmeister (bergmeister) merged 36 commits intoPowerShell:masterPowerShell/PSScriptAnalyzer:masterfrom bergmeister:multi-stage-yamlbergmeister/PSScriptAnalyzer:multi-stage-yamlCopy head branch name to clipboard

Conversation

Christoph Bergmeister (bergmeister) commented Feb 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Multi-stage pipelines (to split build->test)#1404
Christoph Bergmeister (bergmeister) merged 36 commits into
PowerShell:masterfrom
bergmeister:multi-stage-yaml

Christoph Bergmeister (bergmeister) commented Feb 3, 2020 •
edited
Loading