Set default of CheckParameter configuration setting to false when settings are not present - #1411
Merged
Christoph Bergmeister (bergmeister) merged 1 commit intoFeb 9, 2020
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…e that setting won't be enabled by default if an old version of the VS-Code extension uses a new version of PSScriptAnalyzer (1.19)
Christoph Bergmeister (bergmeister)
requested review from
James Truher (JamesWTruher) and
Rob Holt (rjmholt)
February 9, 2020 15:56
Rob Holt (rjmholt)
approved these changes
Feb 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a tweak of #1391, which introduced this new rule option.
Although the setting option is already turned off in all the code formatting setting files, this is to also cover cases where the currwent version of the VS-Code extension uses a new version of PSScriptAnalyzer (1.19)
Because a new version of PSScriptAnalyzer is always published before a new version of the PS extension (where it would be turned off by default as well), this makes sure the setting is truly off by default.
PR Checklist