| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
… invalid test case
I think that's worth doing. That class exists to allow JSON serialisation of versions across PowerShell versions, so it's not really necessary in the tests. Thanks for fixing this Christoph Bergmeister (@bergmeister)! |
Sorry, something went wrong.
|
OK, I will merge this and open a 2nd PR later to add the capability of parsing a single character version |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
The $genericVerCases test case object was not being used due to what seems to have been a copy-paste error.
One test case actually did not work because having a version string with not dot would throw here
I could add the following negative test for it but was wondering why we cannot make it accept single character versions?
In the case of PowerShell Core we wouldn't even need our own implementation and just use System.Management.Automation.SemanticVersion, which can actually parse versions without a dot.
PR Checklist