Pester v5 - #1444
Merged
Christoph Bergmeister (bergmeister) merged 85 commits intoJun 11, 2020
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
added 30 commits
April 12, 2020 21:00
…some -Skip problems already
…1 to fix indentation
added 10 commits
May 16, 2020 10:02
… into pesterv5PoC
… into pesterv5PoC # Conflicts: # Tests/Rules/UseUsingScopeModifierInNewRunspaces.tests.ps1
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
May 27, 2020 17:20
Copy link
Copy Markdown
Collaborator
Author
|
Rob Holt (@rjmholt) James Truher (@JamesWTruher) Pester v5 has released today after multiple RC iterations. It's much cleaner but a tad slower, especially on PowerShell 5.1, which hasn't back-ported the speculative execution perf fix PowerShell/PowerShell#10269 |
Sorry, something went wrong.
Rob Holt (rjmholt)
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Part way through the review, will continue later
Sorry, something went wrong.
Comment thread
PSCompatibilityCollector/Tests/UtilityApi.Tests.ps1
Outdated
Comment thread
Tests/Engine/CustomizedRule.tests.ps1
Outdated
Comment thread
Tests/Engine/InvokeScriptAnalyzer.tests.ps1
Outdated
Comment thread
Tests/Engine/InvokeScriptAnalyzer.tests.ps1
Outdated
Comment thread
Tests/Engine/InvokeScriptAnalyzer.tests.ps1
Outdated
Comment thread
Tests/Engine/CustomizedRule.tests.ps1
Outdated
Rob Holt (rjmholt)
approved these changes
Jun 4, 2020
added 8 commits
June 7, 2020 20:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Migration to use new Pester v5.
It has cleaner scoping and test setup has to go into a BeforeAll block, except for things that need to be evaluated at discovery time (therefore test cases also had to be inlined), see https://github.com/pester/Pester/blob/v5.0/README.md
Some cleanup had to be done as part of it. PSScriptAnalyzer is now only imported once before running tests (import is needed as some tests reference the PSSA types). Some tests were also cleaned up to not depend on PSScriptAnalyzerTestHelper.psm1 any more. I also started adding the Copyright header to the test files. The speed of test execution is roughly the same as v4.
A diff that ignores indentation/whitespace will make the review much easier
I suggest we wait for the GA of v5 but the PR is already ready.
PR Checklist