FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Cleanup csproj files: Remove code duplication for Configuration and entries in Rules project, since it depends on Engine project by bergmeister · Pull Request #1450 · PowerShell/PSScriptAnalyzer · GitHub

Cleanup csproj files: Remove code duplication for Configuration and entries in Rules project, since it depends on Engine project - #1450

Merged
Christoph Bergmeister (bergmeister) merged 1 commit into
PowerShell:masterfrom
bergmeister:chore/cleanupCsproj
Apr 20, 2020
Merged

Cleanup csproj files: Remove code duplication for Configuration and entries in Rules project, since it depends on Engine project#1450
Christoph Bergmeister (bergmeister) merged 1 commit into
PowerShell:masterfrom
bergmeister:chore/cleanupCsproj

Conversation

Christoph Bergmeister (bergmeister) commented Apr 18, 2020
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

This is a cleanup of PR #1425:
After that PR, building locally via Visual Studio or dotnet build was not working any more because it did not cater for the Configuration being either Debug or Release. Since the code for Configuration PSV6Debug and PSV6Releasewere the same the condition fore the configuration was removed, thereby removing unnecessary code duplication and making the case ofDebugorReleasework again, whilst not changing existing behaviour. Also: Since theRulesproject depends on theEngine` project, there is no need to duplicate the reference to SMA (which was actually forgotten to be switched from the SDK to SMA in one project).

PR Checklist

…ntries in Rules project, since it depends on Engine project
Christoph Bergmeister (bergmeister) merged commit 89f2846 into PowerShell:master Apr 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL