Cleanup csproj files: Remove code duplication for Configuration and entries in Rules project, since it depends on Engine project by bergmeister · Pull Request #1450 · PowerShell/PSScriptAnalyzer · GitHub
This is a cleanup of PR #1425:
After that PR, building locally via Visual Studio or dotnet build was not working any more because it did not cater for the Configuration being either Debug or Release. Since the code for Configuration PSV6Debug and PSV6Releasewere the same the condition fore the configuration was removed, thereby removing unnecessary code duplication and making the case ofDebugorReleasework again, whilst not changing existing behaviour. Also: Since theRulesproject depends on theEngine` project, there is no need to duplicate the reference to SMA (which was actually forgotten to be switched from the SDK to SMA in one project).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a cleanup of PR #1425:
After that PR, building locally via Visual Studio or dotnet build was not working any more because it did not cater for the Configuration being either Debug or Release. Since the code for Configuration PSV6Debug and PSV6Releasewere the same the condition fore the configuration was removed, thereby removing unnecessary code duplication and making the case ofDebugorReleasework again, whilst not changing existing behaviour. Also: Since theRulesproject depends on theEngine` project, there is no need to duplicate the reference to SMA (which was actually forgotten to be switched from the SDK to SMA in one project).
PR Checklist