FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Invoke-Formatter: Skip VariableAnalysis, which is not used by Formatter rules - this yields a 25% performance improvement by bergmeister · Pull Request #1451 · PowerShell/PSScriptAnalyzer · GitHub

/ PSScriptAnalyzer Public

Invoke-Formatter: Skip VariableAnalysis, which is not used by Formatter rules - this yields a 25% performance improvement - #1451

Merged
James Truher (JamesWTruher) merged 1 commit into
PowerShell:masterfrom
bergmeister:formatter/speed-skipVariableAnalysis
Apr 21, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Invoke-Formatter: Skip VariableAnalysis, which is not used by Formatter rules - this yields a 25% performance improvement#1451
James Truher (JamesWTruher) merged 1 commit into
PowerShell:masterfrom
bergmeister:formatter/speed-skipVariableAnalysis

Conversation

Christoph Bergmeister (bergmeister) commented Apr 18, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Formatter rules do not call APIs from VariableAnalysis, therefore skipping its initialization makes formatting much faster.
For PowerShell's 3000 line build.psm1 file, this changes execution time from 2 seconds to 1.5 seconds.

PR Checklist

Christoph Bergmeister (bergmeister) changed the title Invoke-Formatter: Skip VariableAnalysis, which is not used by Formatter rules - this yields a 25%-50% performance improvement Invoke-Formatter: Skip VariableAnalysis, which is not used by Formatter rules - this yields a 25% performance improvement Apr 19, 2020
James Truher (JamesWTruher) merged commit bd5a4b1 into PowerShell:master Apr 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
Rob Holt (rjmholt) rjmholt approved these changes
James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area - Formatter Area - Performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL