FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make sure that tests results file gets uploaded in CI when there is a test failure by bergmeister · Pull Request #1455 · PowerShell/PSScriptAnalyzer · GitHub

/ PSScriptAnalyzer Public

Make sure that tests results file gets uploaded in CI when there is a test failure - #1455

Merged
Christoph Bergmeister (bergmeister) merged 1 commit into
PowerShell:masterfrom
bergmeister:YamlSucks
Apr 20, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Make sure that tests results file gets uploaded in CI when there is a test failure#1455
Christoph Bergmeister (bergmeister) merged 1 commit into
PowerShell:masterfrom
bergmeister:YamlSucks

Conversation

Christoph Bergmeister (bergmeister) commented Apr 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Due to too much indentation condition was not applied, I did test in another branch that in case there is a test failure, it actually works.
And that my friends is why I (don't) love yaml....
https://noyaml.com/

PR Checklist

Christoph Bergmeister (bergmeister) changed the title Make sure that tests results file always get uploaded in CI (due to too much indentation condition was not applied) Make sure that tests results file also gets uploaded in CI when there is a test failure Apr 20, 2020
Christoph Bergmeister (bergmeister) changed the title Make sure that tests results file also gets uploaded in CI when there is a test failure Make sure that tests results file gets uploaded in CI when there is a test failure Apr 20, 2020
James Truher (JamesWTruher) approved these changes Apr 20, 2020
View reviewed changes

James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

Christoph Bergmeister (bergmeister) merged commit 5158f4f into PowerShell:master Apr 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
Rob Holt (rjmholt) rjmholt approved these changes
James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL