Use separate test.yaml files files since param passing of pwsh still doesn't seem to fully work correctly by bergmeister · Pull Request #1466 · PowerShell/PSScriptAnalyzer · GitHub

PR Summary

See https://developercommunity.visualstudio.com/content/problem/996647/boolean-compile-time-yaml-expression-not-correctly.html

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

This reverts commit 517ba15.

# Conflicts: # .azure-pipelines-ci/templates/test-powershell.yaml

… into ci-fix-param-passing

lgtm

Christoph Bergmeister added 13 commits April 25, 2020 23:32

Pass pwsh parameter explicitly as runtime parameter

92df6c4

fix yaml

f270590

try use compile time expression

f60a154

cannot cast to bool, use string

637b3bc

compile time expressions everywhere

517ba15

Revert "compile time expressions everywhere"

ca76515

This reverts commit 517ba15.

runtime expr

3af2262

try use $() expression and don't pass parameter

01a7d39

try re-add param section

8eed77d

try use bracket again

66cb8ab

try split test template

fc361a3

# Conflicts: # .azure-pipelines-ci/templates/test-powershell.yaml

Merge branch 'master' of https://github.com/powershell/psscriptanalyzer …

5d40207

… into ci-fix-param-passing

re-enable build

90ad293

Christoph Bergmeister (bergmeister) added the Area - Build label Apr 28, 2020

Christoph Bergmeister (bergmeister) marked this pull request as ready for review April 28, 2020 20:37

Christoph Bergmeister (bergmeister) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) April 28, 2020 20:37

remove duplicated entry

765748d

James Truher (JamesWTruher) approved these changes Apr 29, 2020

View reviewed changes

James Truher (JamesWTruher) merged commit c005599 into PowerShell:master Apr 29, 2020

Use separate test.yaml files files since param passing of pwsh still doesn't seem to fully work correctly by bergmeister · Pull Request #1466 · PowerShell/PSScriptAnalyzer · GitHub

Uh oh!

Use separate test.yaml files files since param passing of pwsh still doesn't seem to fully work correctly - #1466

Use separate test.yaml files files since param passing of pwsh still doesn't seem to fully work correctly#1466
James Truher (JamesWTruher) merged 14 commits into
PowerShell:masterfrom
bergmeister:ci-fix-param-passing

Christoph Bergmeister (bergmeister) commented Apr 28, 2020 •
edited
Loading

Uh oh!

Uh oh!

James Truher (JamesWTruher) left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Use separate test.yaml files files since param passing of pwsh still doesn't seem to fully work correctly by bergmeister · Pull Request #1466 · PowerShell/PSScriptAnalyzer · GitHub

Uh oh!

Use separate test.yaml files files since param passing of pwsh still doesn't seem to fully work correctly - #1466

Conversation

Christoph Bergmeister (bergmeister) commented Apr 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

James Truher (JamesWTruher) left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Christoph Bergmeister (bergmeister) commented Apr 28, 2020 •
edited
Loading