UseConsistentWhitespace: Fix CheckParameter bug when using interpolated string - #1498
Merged
Christoph Bergmeister (bergmeister) merged 1 commit intoMay 18, 2020
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
requested review from
James Truher (JamesWTruher) and
Rob Holt (rjmholt)
May 14, 2020 17:07
Rob Holt (rjmholt)
approved these changes
May 14, 2020
This was referenced Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1495
I thought the searchNestedScriptBlocks: false option would not make it return nested objects in commandAst.FindAll. However, for an interpolated string, the VariableExpressionAst of the ExpendableStringExpressionAst is returned as well, therefore checking that only AST are returned whose parent is the commandAst.
PR Checklist