Set Assembly version attribute for 1.19.1 release - #1549
Merged
James Truher (JamesWTruher) merged 2 commits intoJul 22, 2020
Merged
Set Assembly version attribute for 1.19.1 release#1549James Truher (JamesWTruher) merged 2 commits into
James Truher (JamesWTruher) merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Rob Holt (rjmholt)
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
We should also set the version for Microsoft.PowerShell.CrossCompatibility.
Ideally in future we can use a more centralised configuration, like PSScriptAnalyzer.Common.props or something, to set this in one place. We possibly also discussed a YAML configuration for this
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Yes to doing it also for Microsoft.PowerShell.CrossCompatibility.dll. Please update the changelog with this PR. I am not sure why (and if) we need the existing VersionPrefix property, which is also not present in Microsoft.PowerShell.CrossCompatibility.dll at the moment |
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
this change puts an assembly version on the analyzer assemblies, so you can see the version by inspection of the assembly
PR Checklist