FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make CI fail if tests fail and fix failing tests by making them Pester v5 compatible by bergmeister · Pull Request #1553 · PowerShell/PSScriptAnalyzer · GitHub

Make CI fail if tests fail and fix failing tests by making them Pester v5 compatible - #1553

Merged
Christoph Bergmeister (bergmeister) merged 2 commits into
PowerShell:masterfrom
bergmeister:FixTests
Jul 28, 2020
Merged

Make CI fail if tests fail and fix failing tests by making them Pester v5 compatible#1553
Christoph Bergmeister (bergmeister) merged 2 commits into
PowerShell:masterfrom
bergmeister:FixTests

Conversation

Christoph Bergmeister (bergmeister) commented Jul 24, 2020
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

The migration to Pester v5 meant that the switch to make CI fail if there was a test failure, was not on. I did an individual commit for this fix so that you can see it fails now when there is a failed test.
Fix failing tests by making them Pester v5 compatible, this was because the PR that added those tests was opened before the Pester v5 migration.

PR Checklist

Christoph Bergmeister (bergmeister) changed the title Make CI fail if tests fail Make CI fail if tests fail and fix failing tests by making them Pester v5 compatible Jul 24, 2020
Christoph Bergmeister (bergmeister) marked this pull request as ready for review July 24, 2020 17:25
Christoph Bergmeister (bergmeister) merged commit 3d225ba into PowerShell:master Jul 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL