Remove conditional compilation for PSv6 and therefore netstandard2.0 for Engine and Rules projects - #1600
Merged
Rob Holt (rjmholt) merged 4 commits intoNov 10, 2020
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…for Engine/Rules project
Comment thread
Engine/PSScriptAnalyzer.psm1
| $binaryModuleRoot = Join-Path -Path $PSModuleRoot -ChildPath "PSv$($PSVersionTable.PSVersion.Major)" | ||
| } | ||
| elseif ($PSVersionTable.PSVersion.Major -eq 6 ) { | ||
| [Version] $minimumPowerShellCoreVersion = '7.0.3' |
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
I chose to bump not just from 6.2.4 to 7.0.0 but also to 7.0.3 in anticipation of PR #1597 getting merged, which will bump the minimum version to 7.0.3. Since 7.0.2 is not supported anyway because 7.0.3 is already more than a month old, this should not be an issue.
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
requested review from
James Truher (JamesWTruher) and
Rob Holt (rjmholt)
October 25, 2020 20:51
James Truher (JamesWTruher)
approved these changes
Nov 3, 2020
Rob Holt (rjmholt)
approved these changes
Nov 3, 2020
Comment thread
Rules/Rules.csproj
| <ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp3.1' "> | ||
| <PackageReference Include="System.Reflection.TypeExtensions" Version="4.7.0" /> | ||
| <PackageReference Include="Microsoft.Management.Infrastructure" Version="2.0.0" /> | ||
| <Compile Remove="UseSingularNouns.cs" /> |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I put this in the same block since the previous PR did the same, but I'd be happy to move it to its own block too
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is due to PS 6.2 having reached EOL. The Engine and Rules projects target netcoreapp3.1 for PS 7, therefore the netstandard2.0 compilation target for them is not needed any more. Because the CrossCompatility project is still generic and is not targeting netcoreapp3.1 for PS 7, we can and should keep that project using netstandard2.0.
This will make the module smaller in size and the build faster as a nice side-effect.
PR Checklist