🧹 Make usage of Microsoft.Management.Infrastructure consistent and reference it only once in CrossCompatibility project - #1601
Merged
Rob Holt (rjmholt) merged 2 commits intoNov 3, 2020
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…tibility project for consistency
Christoph Bergmeister (bergmeister)
requested review from
James Truher (JamesWTruher) and
Rob Holt (rjmholt)
October 25, 2020 20:52
Rob Holt (rjmholt)
approved these changes
Nov 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is to have consistency with what we actually already do in the Rules project and its configuration currently applies as it is the 'root' project: https://github.com/PowerShell/PSScriptAnalyzer/blob/master/Rules/Rules.csproj#L18-L2
Since the project depends on CrossCompatibility, we can reference the Microsoft.Management.Infrastructure only once in there to avoid duplication and consistencies that we currently have.
PR Checklist