UseConsistentWhitespace.CheckOperator: Add unary operators that start with a dash (-split, -join, -not, -bnot, isplit, csplit) - #1602
Draft
Christoph Bergmeister (bergmeister) wants to merge 9 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
requested review from
James Truher (JamesWTruher) and
Rob Holt (rjmholt)
October 25, 2020 20:51
Copy link
Copy Markdown
Contributor
|
I tried this code out and noticed a couple things. |
Sorry, something went wrong.
Comment thread
Rules/UseConsistentWhitespace.cs
Rob Holt (rjmholt)
approved these changes
Apr 21, 2021
Rob Holt (rjmholt)
marked this pull request as draft
April 21, 2021 20:57
Copy link
Copy Markdown
Contributor
|
Converting to draft to resolve the various PRs |
Sorry, something went wrong.
James Truher (JamesWTruher)
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot will automatically review once the pull request is marked ready for review
At least 1 approving review is required to merge this pull request.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Related: #1239
In order to enable formatting corrections of this kind: $a-join$b --> $a -join $b or reducing too much whitespace but also -split$a --> -split $a with the added code as existing code for operators assumes that something precedes it.
The reason for adding the check that the unary operator starts with a dash is is to exclude things like $a++ or !$a where we do not want a whitespace character separation by default
PR Checklist