FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Replace words with racial connotation (use allowlist and blocklist as an alternative) by bergmeister · Pull Request #1604 · PowerShell/PSScriptAnalyzer · GitHub

/ PSScriptAnalyzer Public

Replace words with racial connotation (use allowlist and blocklist as an alternative) - #1604

Merged
Rob Holt (rjmholt) merged 2 commits into
PowerShell:masterfrom
bergmeister:RemoveWordsWithRacialConnotation
Nov 3, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Replace words with racial connotation (use allowlist and blocklist as an alternative)#1604
Rob Holt (rjmholt) merged 2 commits into
PowerShell:masterfrom
bergmeister:RemoveWordsWithRacialConnotation

Conversation

Christoph Bergmeister (bergmeister) commented Oct 25, 2020

Copy link
Copy Markdown
Collaborator

PR Summary

This does not replace all words with a racial connotation because one word is the setting name of the PSAvoidUsingCmdletAliases rule. Therefore an alternative setting name is being added, whilst allowing the current one to still work. The idea is that we give users time to adapt in the next version but completely remove the setting with a racial connotation in the version after that.

PR Checklist

Christoph Bergmeister (bergmeister) marked this pull request as ready for review October 25, 2020 20:50
Rob Holt (rjmholt) reviewed Nov 3, 2020
View reviewed changes

Rob Holt (rjmholt) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

My only worry here is that this is a public configuration key, so that changing its name will break existing configurations

Rob Holt (rjmholt) commented Nov 3, 2020

Copy link
Copy Markdown
Contributor

My only worry here is that this is a public configuration key, so that changing its name will break existing configurations

Oh I see from your description that this is an alternative!

Rob Holt (rjmholt) merged commit 4857578 into PowerShell:master Nov 3, 2020

Christoph Bergmeister (bergmeister) commented Nov 3, 2020

Copy link
Copy Markdown
Collaborator Author

Yes, it is an alternative/alias for the existing settings but once a new version of pssa is released with that, which would give people time to adapt I am tempted to remove the original setting name completely in the following release but that's a discussion for another day, which will probably not happen until in 6 months time....

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
1 more reviewer
Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL