FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

move to new signing process for release build and prep for 1.20.0 by JamesWTruher · Pull Request #1625 · PowerShell/PSScriptAnalyzer · GitHub

/ PSScriptAnalyzer Public

move to new signing process for release build and prep for 1.20.0 - #1625

Merged
Rob Holt (rjmholt) merged 36 commits into
PowerShell:masterfrom
JamesWTruher:releaseBuild002
Apr 22, 2021
ConversationCommits (36)ChecksFiles changed
Merged

move to new signing process for release build and prep for 1.20.0#1625
Rob Holt (rjmholt) merged 36 commits into
PowerShell:masterfrom
JamesWTruher:releaseBuild002

Conversation

James Truher (JamesWTruher) commented Jan 13, 2021

Copy link
Copy Markdown
Contributor

PR Summary

The infrastructure at MS has changed with regard to signing, this PR allows us to use it.

PR Checklist

Rob Holt (rjmholt) self-requested a review January 13, 2021 19:15
Christoph Bergmeister (bergmeister) reviewed Jan 14, 2021
View reviewed changes

Christoph Bergmeister (bergmeister) left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks good but the build seems to be broken. Also wondering whether 1.20.0 would be a better target version since the changes are all small improvements but not fixes

First cut at new release/signing build yml
150d81e
remove display name from incorrect location
7943547
change paths for changes in build system
232cb28
add debugging info
21a029a
Be sure to build all versions
daadefc
change debugging code for 'Copy signed files'
1faf27b
be sure to be in the correct location for creating the nupkg
d47c013
Change nupkg building logic
fd6d5c2
make not finding dotnet.exe a non fatal error for loading the module
57d4635
fix path to suppression file
308f923
debugging statements for compliance
2d1f8f4
fix typo for credscan suppressions
5495b95 
Add binskim scan directory
Update to publish build directory
b535c72 
Also publish nupkg directly from signed directory
Be sure to publish the build directory
caf23fa 
and don't publish the out directory, publishing the signed directory is enough
published signed files need their own name
f9231e5
add exception for README.md for cred scanner
91e0921 
Fix up path for binskim
try to get binskim to work with more direct path to assemblies
7fafc46
debugging to find issues with signing files
484c051
fix typo
8a6aeb2
more debugging
0794d19
remove debugging
39edbf6
remove publish of nupkg
a55814b
remove newtonsoft signing stage
275cbf2
try the newton soft signing again
3dab1f9
disable newtonsoft signing
29e870d

James Truher (JamesWTruher) commented Feb 10, 2021

Copy link
Copy Markdown
Contributor Author

I've rebased to be up to date.

Christoph Bergmeister (@bergmeister), Rob Holt (@rjmholt), Sydney Smith (@SydneyhSmith) - Chris is suggesting that our next release should perhaps be number 1.20.0 and I wanted everyone to have a chance to provide an opinion. FWIW, I'm ok with 1.20

Rob Holt (rjmholt) approved these changes Feb 10, 2021
View reviewed changes

Rob Holt (rjmholt) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM -- agree that 1.20 seems good

Travis Plunk (TravisEz13) reviewed Feb 10, 2021
View reviewed changes

Travis Plunk (TravisEz13) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks about right to me

Christoph Bergmeister (bergmeister) changed the title move to new signing process for release build and prep for 1.19.2 move to new signing process for release build and prep for 1.20.0 Feb 10, 2021
Rob Holt (rjmholt) approved these changes Apr 21, 2021
View reviewed changes

Rob Holt (rjmholt) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Generally looks good, just a small comment about the Write-Host invocations

Comment thread .ci/releaseBuild.yml Outdated
Update .ci/releaseBuild.yml
c0714ab 
Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
Rob Holt (rjmholt) reviewed Apr 21, 2021
View reviewed changes
Comment thread .ci/releaseBuild.yml Outdated
Comment thread .ci/releaseBuild.yml Outdated
Comment thread .ci/releaseBuild.yml Outdated
Comment thread .ci/releaseBuild.yml Outdated
Rob Holt (rjmholt) merged commit 6bdc6f4 into PowerShell:master Apr 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Christoph Bergmeister (bergmeister) bergmeister approved these changes
+2 more reviewers
Rob Holt (rjmholt) rjmholt approved these changes
Travis Plunk (TravisEz13) TravisEz13 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

James Truher (JamesWTruher)

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL