FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make UseSingularNouns rule work on PowerShell Core by bergmeister · Pull Request #1627 · PowerShell/PSScriptAnalyzer · GitHub

/ PSScriptAnalyzer Public

Make UseSingularNouns rule work on PowerShell Core - #1627

Merged
Rob Holt (rjmholt) merged 46 commits into
PowerShell:masterfrom
bergmeister:UseSingularNoun_PSCore
Apr 28, 2021
ConversationCommits (46)ChecksFiles changed
Merged

Make UseSingularNouns rule work on PowerShell Core#1627
Rob Holt (rjmholt) merged 46 commits into
PowerShell:masterfrom
bergmeister:UseSingularNoun_PSCore

Conversation

Christoph Bergmeister (bergmeister) commented Jan 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Fixes #1626

This uses the open source Pluralize.NET NuGet package, which uses the MIT licence. The added payload is only 20KB once.
Also enhance existing code to not construct Pluralizationservice in foreach loop.

PR Checklist

Christoph Bergmeister (bergmeister) changed the title Make UseSingularNouns rule work for PowerShell Core versions Make UseSingularNouns rule work on PowerShell Core Jan 23, 2021
Closed
Christoph Bergmeister (bergmeister) marked this pull request as ready for review January 23, 2021 10:43

Sydney Smith (SydneyhSmith) commented Feb 3, 2021

Copy link
Copy Markdown
Collaborator

Ah unfortunately, the fact that the package is unlicensed does block us from accepting it

Christoph Bergmeister (bergmeister) commented Feb 3, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Ok, will contact the author if an MIT license or something similar can be added as it was probably not intentional by the author. Would the licence need to be on the NuGet package or just the source repo?
Alternatively, there is a similar NuGet package with MIT license but that is not preferred as the implementation is different to the one that I suggested, which is just a .Net Core port.
https://github.com/sarathkcm/Pluralize.NET

Christoph Bergmeister (bergmeister) commented Feb 7, 2021

Copy link
Copy Markdown
Collaborator Author

Sydney Smith (@SydneyhSmith) I updated it to use the Pluralize.NET library instead, which has an MIT licence.

Sydney Smith (SydneyhSmith) commented Feb 16, 2021

Copy link
Copy Markdown
Collaborator

Thanks Christoph Bergmeister (@bergmeister) that package looks good to us

Rob Holt (rjmholt) reviewed Feb 17, 2021
View reviewed changes
Comment thread Rules/UseSingularNouns.cs Outdated
Comment thread Rules/UseSingularNouns.cs Outdated
Comment thread Tests/Engine/GetScriptAnalyzerRule.tests.ps1 Outdated
Comment thread Rules/UseSingularNouns.cs Outdated
Rob Holt (rjmholt) self-assigned this Apr 22, 2021
Rob Holt (rjmholt) merged commit 1eb5671 into PowerShell:master Apr 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
James Truher (JamesWTruher) JamesWTruher left review comments
Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

Rob Holt (rjmholt)

Labels

Area - Rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PSUseSingularNouns Rule doesn't work in PowerShell Core but does in PowerShell

4 participants

Back | FazBrowse Home | New Git URL