FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Simplify devcontainer setup and resolve git line ending conflicts by bergmeister · Pull Request #1637 · PowerShell/PSScriptAnalyzer · GitHub

Simplify devcontainer setup and resolve git line ending conflicts - #1637

Merged
Rob Holt (rjmholt) merged 2 commits into
PowerShell:masterfrom
bergmeister:devContainerImprovement
Apr 21, 2021
Merged

Simplify devcontainer setup and resolve git line ending conflicts#1637
Rob Holt (rjmholt) merged 2 commits into
PowerShell:masterfrom
bergmeister:devContainerImprovement

Conversation

Copy link
Copy Markdown
Collaborator

PR Summary

  • The .gitattributes change is so that VS-Code does not see red-herring diffs due to different line endings when using devcontainer (Remote Contaienr or GitHub CodeSpaces). This is taken from the docs here: https://code.visualstudio.com/docs/remote/troubleshooting#_resolving-git-line-ending-issues-in-containers-resulting-in-many-modified-files
  • Remove some setup in the Dockerfile that is not necessary for PSSA development. The Dockerfile was originally taken from a generic .NET template for the new devcontainer feature, therefore I can now remove the old licence text. I believe that setup is more geared towards scenarios happen in ASP.NET development but not for the development of this module.

PR Checklist

Comment thread .devcontainer/Dockerfile Outdated
Comment thread .gitattributes Outdated
Rob Holt (rjmholt) merged commit ec1c58d into PowerShell:master Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL