Fix NRE when custom rules omit optional properties in diagnostics - #1715
Merged
James Truher (JamesWTruher) merged 3 commits intoSep 28, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Rob Holt (rjmholt)
requested review from
James Truher (JamesWTruher) and
Christoph Bergmeister (bergmeister)
September 16, 2021 19:58
Christoph Bergmeister (bergmeister)
approved these changes
Sep 17, 2021
Christoph Bergmeister (bergmeister)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Looks good, only suggestion is to replace hard-coded property names with code references using things like e.g. nameof. Also, should we try to make the property query case insensitive for the property name itself as I think at the moment it'd be case sensitive
Sorry, something went wrong.
James Truher (JamesWTruher)
approved these changes
Sep 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1714.
These changes allow custom rules to emit diagnostics (or PSObjects that turn into diagnostics) with optional properties unset.
PR Checklist