Fixes #1720 - move rule docs and update tests - #1724
Merged
Sean Wheeler (sdwheeler) merged 2 commits intoOct 5, 2021
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Looks like platyPS invocations in the build script also need to be updated |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Rob Holt (@rjmholt) OK, I missed that. Will update. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Rob Holt (@rjmholt) Fixed the build script. |
Sorry, something went wrong.
Sean Wheeler (sdwheeler)
enabled auto-merge (squash)
October 5, 2021 21:58
Rob Holt (rjmholt)
approved these changes
Oct 5, 2021
4 tasks
Copy link
Copy Markdown
Member
|
Hi, Rob Holt (@rjmholt) and Sean Wheeler (@sdwheeler) this PR caused a regression in the VS Code extension because the URL used to find the documentation was changed. Heads up to coordinate changes like this in the future. I'm pushing a new release today with the bug-fix. |
Sorry, something went wrong.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
Moved ./RulesDocumentation to ./docs/Rules
Moved ./docs/markdown to ./docs/Cmdlets
Update Pester test for documentation
PR has a meaningful title
Summarized changes
Change is not breaking
Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
This PR is ready to merge and is not Work in Progress.