Be sure not to clobber existing files when installing dotnet. - #1788
Merged
James Truher (JamesWTruher) merged 1 commit intoMay 23, 2022
Merged
Be sure not to clobber existing files when installing dotnet.#1788James Truher (JamesWTruher) merged 1 commit into
James Truher (JamesWTruher) merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This is the same fix as PowerShell/PowerShell#17141
James Truher (JamesWTruher)
requested a review
from Christoph Bergmeister (bergmeister)
April 12, 2022 21:48
Christoph Bergmeister (bergmeister)
approved these changes
Apr 14, 2022
Christoph Bergmeister (bergmeister)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Lgtm
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same fix as PowerShell/PowerShell#17141
PR Summary
installing a new dotnet will clobber the current executables causing all sorts of trouble (dotnet will stop working entirely)
PR Checklist