Upgrade from net452 to net462 for Windows PowerShell - #1789
Merged
James Truher (JamesWTruher) merged 8 commits intoJul 5, 2022
Merged
Upgrade from net452 to net462 for Windows PowerShell#1789James Truher (JamesWTruher) merged 8 commits into
James Truher (JamesWTruher) merged 8 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
… into net462 # Conflicts: # README.md
… into net462 # Conflicts: # README.md
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
May 27, 2022 16:22
James Truher (JamesWTruher)
approved these changes
Jul 5, 2022
James Truher (JamesWTruher)
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Upgrading since older framework version will go out of support and and targeting a newer version will allow us to use more APIs. 4.6.2 is the older, still supported one
https://devblogs.microsoft.com/dotnet/net-framework-4-5-2-4-6-4-6-1-will-reach-end-of-support-on-april-26-2022/
As part of it I also fixed a bug that was introduced in PR #1425 where one line of code wasn't upgraded from PSV6 to PSV7
Furthermore APIs are being used that are in net462 but weren't available in net452
PR Checklist