Sync changes from docs repo - #1814
Merged
Christoph Bergmeister (bergmeister) merged 1 commit intoJul 11, 2022
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Sean Wheeler (sdwheeler)
requested a review
from Christoph Bergmeister (bergmeister)
June 30, 2022 14:15
Copy link
Copy Markdown
Collaborator
Author
|
Christoph Bergmeister (@bergmeister) For your review |
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
approved these changes
Jun 30, 2022
Christoph Bergmeister (bergmeister)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Looks good to me. It's good we finally put the limitation around scriptblock scope into docs. I'm not sure folks will still understand it though what it means in terms of expected false positives. But this should not block this PR, I think I will take a note to add a couple of known false positives in another PR as it's a frequent source of opened issues (as well as user frustration)
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Copies the changes from PR MicrosoftDocs/PowerShell-Docs-Modules#74 that fixes issue MicrosoftDocs/PowerShell-Docs-Modules#17.
PR Checklist