Fix 'Accept pipeline input' properties in documentation of Invoke-Formatter - #1833
Merged
James Truher (JamesWTruher) merged 1 commit intoAug 30, 2022
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
requested review from
James Truher (JamesWTruher) and
Sean Wheeler (sdwheeler)
August 27, 2022 13:49
Sean Wheeler (sdwheeler)
approved these changes
Aug 27, 2022
Sean Wheeler (sdwheeler)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Comment thread
Tests/Engine/ModuleHelp.Tests.ps1
| foreach($parameterAttribute in $parameter.Attributes) { | ||
| if ($parameterAttribute.ValueFromPipeline -eq $null) { continue } | ||
|
|
||
| $parameterHelpPipelineInput = if ($parameterHelp.pipelineInput -eq 'True (ByPropertyName, ByValue)') { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
is the string format of this going to be consistent
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
yes and if not the test will fail anyway :-)
Sorry, something went wrong.
James Truher (JamesWTruher)
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR #1763 made Invoke-Formatter accept pipeline input but tests didn't catch that cmdlet docs weren't updated. This fixes the docs and adds tests for pipeline input. Since that pull request hasn't been released yet, no need to update Microsoft docs.
PR Checklist