AvoidUsingPositionalParameter: Check if command has parameters to avoid having az in default CommandAllowList - #1850
Merged
Christoph Bergmeister (bergmeister) merged 5 commits intoFeb 13, 2024
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
October 25, 2022 16:43
Copy link
Copy Markdown
Contributor
|
Christoph Bergmeister (@bergmeister) should we have any validation for this new behavior? Not about removing "az", but rather the command having no parameters |
Sorry, something went wrong.
James Truher (JamesWTruher)
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
just 1 question
Sorry, something went wrong.
Comment thread
Rules/AvoidPositionalParameters.cs
Outdated
Christoph Bergmeister (bergmeister)
enabled auto-merge (squash)
February 12, 2024 18:10
James Truher (JamesWTruher)
approved these changes
Feb 13, 2024
James Truher (JamesWTruher)
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
this is fine
Sorry, something went wrong.
This was referenced Mar 16, 2024
Rob Holt (rjmholt)
added a commit
to rjmholt/PSScriptAnalyzer
that referenced
this pull request
Feb 23, 2026
UseDeclaredVarsMoreThanAssignments (PowerShell#2013): skip scope-qualified variable references ($global:, $script:, drive-qualified) when checking for uses of local variables, preventing false negatives. AvoidPositionalParameters (PowerShell#1850): skip commands that have no parameters in the database (e.g. native CLI tools like az). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is an enhancement to CommandAllowList introduced in #1846
To avoid having az as the default in it, return now the discovered command and inspect whether it has parameters. If not, which is the case for the az CLI, then do not continue analyzing usage of that command.
Also, az has backed out their change since then so with latest version of az, we don't need it as default allow-list anyway.
PR Checklist