Generate strongly typed resources as part of build - #1855
Merged
James Truher (JamesWTruher) merged 4 commits intoJan 16, 2024
Merged
Generate strongly typed resources as part of build#1855James Truher (JamesWTruher) merged 4 commits into
James Truher (JamesWTruher) merged 4 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
James Truher (JamesWTruher)
approved these changes
Sep 11, 2023
James Truher (JamesWTruher)
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
this looks good - it's great that we don't need to do this manually.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Christoph Bergmeister (@bergmeister) if you could solve the merge conflict that would be great. |
Sorry, something went wrong.
… into resgen # Conflicts: # Rules/Strings.Designer.cs
Copy link
Copy Markdown
Collaborator
Author
|
James Truher (@JamesWTruher) done. resolution was easy because this PR removes Strings.Designer.cs |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Close and re-open to get latest CI check |
Sorry, something went wrong.
This was referenced Mar 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
At the moment one needs to update the Strings.Designer.cs files when new entries are adding to String.resx files because the .NET CLI cannot generate them by default, which makes it hard for developers that do not use Visual Studio but VS-Code or just CLI. However, there is a way to make this work and generate the strongly resource as part of the build and make it work for CLI, VS-Code (when it does a restore) and Visual Studio, which uses MSBuild, see here: dotnet/msbuild#4751
PR Checklist