FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Convert UseSingularNouns to configurable rule and add Windows to allowlist by MJVL · Pull Request #1858 · PowerShell/PSScriptAnalyzer · GitHub

/ PSScriptAnalyzer Public

Convert UseSingularNouns to configurable rule and add Windows to allowlist - #1858

Merged
Christoph Bergmeister (bergmeister) merged 6 commits into
PowerShell:masterfrom
MJVL:nounFix
Jan 18, 2024
ConversationCommits (6)ChecksFiles changed
Merged

Convert UseSingularNouns to configurable rule and add Windows to allowlist#1858
Christoph Bergmeister (bergmeister) merged 6 commits into
PowerShell:masterfrom
MJVL:nounFix

Conversation

Michael Van Leeuwen (MJVL) commented Nov 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

This PR:

Relevant test has also been added.

PR Checklist

Christoph Bergmeister (bergmeister) reviewed Nov 7, 2022
View reviewed changes

Christoph Bergmeister (bergmeister) left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd be happy to accept it as-is but I am thinking it might be better to expose this allowList as a configurable setting so it can be overridden similar to how we decided to do for this rule when allow-listing az:
https://github.com/PowerShell/PSScriptAnalyzer/pull/1846/files#diff-0c1b69454498d51fc5f5ba732f2589578f37357dd80b111e8330fff529036908

Michael Van Leeuwen (MJVL) commented Nov 7, 2022

Copy link
Copy Markdown
Contributor Author

I'd be happy to accept it as-is but I am thinking it might be better to expose this allowList as a configurable setting so it can be overridden similar to how we decided to do for this rule when allow-listing az: https://github.com/PowerShell/PSScriptAnalyzer/pull/1846/files#diff-0c1b69454498d51fc5f5ba732f2589578f37357dd80b111e8330fff529036908

I agree, as this could cut down on any future issues asking for additional allowList nouns. I can look into refactoring this as a configurable rule.

For the default value, do you think it would still be proper to include {"Data", "Windows"}, or would it be better practice to leave this blank entirely?

Christoph Bergmeister (bergmeister) commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator

Yes, in that case also happy to add Windows to default.

Michael Van Leeuwen (MJVL) changed the title Add Windows to noun allowlist Convert UseSingularNouns to configurable rule and add Windows to allowlist Nov 8, 2022
Christoph Bergmeister (bergmeister) approved these changes Nov 8, 2022
View reviewed changes

Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the additional effort. Looks good to me 👍🏻

Christoph Bergmeister (bergmeister) commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator

Closing and re-opening to re-trigger CI

Christoph Bergmeister (bergmeister) merged commit da64672 into PowerShell:master Jan 18, 2024
This was referenced Mar 16, 2024
Closed
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Christoph Bergmeister (bergmeister) bergmeister approved these changes
+1 more reviewer
James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL