FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make Invoke-Formatter test case assertion fail in case of incorrect casing by alexandear · Pull Request #1888 · PowerShell/PSScriptAnalyzer · GitHub

Make Invoke-Formatter test case assertion fail in case of incorrect casing - #1888

Merged
Christoph Bergmeister (bergmeister) merged 1 commit into
PowerShell:masterfrom
alexandear:test-fix-fmt-case
Feb 10, 2023
Merged

Make Invoke-Formatter test case assertion fail in case of incorrect casing#1888
Christoph Bergmeister (bergmeister) merged 1 commit into
PowerShell:masterfrom
alexandear:test-fix-fmt-case

Conversation

Oleksandr Redko (alexandear) commented Feb 9, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

This PR fixes the test "corrects case of of cmdlet inside interpolated string" for Invoke-Formatter. It follows #1885 which didn't fully fixed the test.

Additional Info

The idea is to use -BeExactly for case-sensitive strings comparison.
With changes in the PR the test fails when the expected string is '"$(get-childItem)"':

[-] UseCorrectCasing.corrects case of of cmdlet inside interpolated string 19ms (17ms|1ms)
 Expected strings to be the same, but they were different.
 String lengths are both 18.
 Strings differ at index 3.
 Expected: '"$(get-childItem)"'
 But was:  '"$(Get-ChildItem)"'
            ---^
 at Invoke-Formatter '"$(get-childitem)"' | Should -BeExactly '"$(get-childItem)"', /Users/redko.o/src/github.com/PowerShell/PSScriptAnalyzer/Tests/Rules/UseCorrectCasing.tests.ps1:14
 at <ScriptBlock>, /Users/redko.o/src/github.com/PowerShell/PSScriptAnalyzer/Tests/Rules/UseCorrectCasing.tests.ps1:14

PR Checklist

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thanks for helping us catch this as well. You are totally right.
cc Ryan Yates (@kilasuit)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL