Add exception message for missing rules - #1968
Merged
Andy Jordan (andyleejordan) merged 5 commits intoMar 14, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
requested review from
Andy Jordan (andyleejordan) and
Christoph Bergmeister (bergmeister)
as code owners
February 17, 2025 21:00
Comment thread
Engine/ScriptAnalyzer.cs
| CultureInfo.CurrentCulture, | ||
| Strings.RulesNotFound), | ||
| ErrorCategory.ResourceExists, | ||
| new Exception(errorMessage), |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
where this error is thrown, are we sure the only reason could be missing rules Tadas Medišauskas (@Tadas) ?
Kicked off CI for now to see what tests say
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Christoph Bergmeister (@bergmeister) I know we didn't get an answer to this; thoughts on merging for v1.3?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
actually, on closer inspection of the diff, only 2 things are changing and they aren't of concern:
- errorMessage is passed into Exception instead of nothing, which is an improvement
- ErrorCategory is changed from ResourceExists to ResourceUnavailable, which I guess is a bit better but ObjectNotFound is maybe even better so will change it to that. This is the same category that gci notExists returns
Sorry, something went wrong.
Comment thread
Engine/ScriptAnalyzer.cs
Outdated
Comment thread
Engine/ScriptAnalyzer.cs
Outdated
Christoph Bergmeister (bergmeister)
approved these changes
Mar 14, 2025
Andy Jordan (andyleejordan)
enabled auto-merge (squash)
March 14, 2025 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1875
PR Checklist