PSReservedParams: Make severity Error instead of Warning - #1989
Merged
Andy Jordan (andyleejordan) merged 2 commits intoFeb 20, 2025
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
approved these changes
Apr 9, 2024
Christoph Bergmeister (bergmeister)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks, I think it's best to fix the code like you did rather than documentation because for this rule, violations result in code that won't even run.
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
requested a review
from Andy Jordan (andyleejordan)
as a code owner
February 17, 2025 20:59
Andy Jordan (andyleejordan)
approved these changes
Feb 20, 2025
Andy Jordan (andyleejordan)
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Comment thread
Rules/AvoidReservedParams.cs
| /// Gets the severity of the returned diagnostic record: error, warning, or information. | ||
| /// </summary> | ||
| /// <returns></returns> | ||
| public DiagnosticSeverity GetDiagnosticSeverity() |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Why do we need a whoel function for this?
Sorry, something went wrong.
Andy Jordan (andyleejordan)
enabled auto-merge (squash)
February 20, 2025 22:55
Liam Peters (liamjpeters)
deleted the
#1973PSReservedParamsGeneratesWarningInsteadOfError
branch
February 21, 2025 11:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PSScriptAnalyzer reports PSReservedParams as warning but according to the documentation it's an error.
This PR makes the rule report as an error and fixes up tests that expect there to be 7 rules with an error severity (this makes it 8).
Resolves #1973
PR Checklist